Sagewire Logo

[jira] Created: (GERONIMO-3714) Monitoring console does no errorchecking on add/edit graph timeframe

12 Message(s) by 2 Author(s) originally posted in developer geronimo java


From: Erik B. Craig Date:   Wednesday, December 19, 2007
Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------

Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. CraigCurrently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.

There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Wednesday, December 19, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen reassigned GERONIMO-3714:
------------------------------------------

Assignee: Viet Hung Nguyen

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Friday, December 21, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3714:
---------------------------------------

Attachment: geronimo-3714.patch

The root cause of this is because the "skipCount" value is equal to 0 in some instances because of integer division. With skipCount = 0, it is meaningless to the method getSpecificStatistics() in the agent. Whenever this happens, I set skipCount = 1, meaning, grab each snapshot without skipping any in between.

Additionally, I also reformatted the MRCConnector.JAVA to abide by the Apache Geronimo coding standards specified at http://geronimo.apache.org/coding-standards.html.

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Friday, December 21, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3714:
---------------------------------------

Attachment: (was: geronimo-3714.patch)

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Friday, December 21, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3714:
---------------------------------------

Attachment: geronimo-3714.patch

I forgot to add the JS checks to ensure that the user cannot specify anything less than 2*(snapshot_duration) for the graph's time window. So I have added that stuff in this new patch

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Erik B. Craig Date:   Friday, December 21, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik B. Craig reassigned GERONIMO-3714:
---------------------------------------

Assignee: Erik B. Craig (was: Viet Hung Nguyen)

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Erik B. Craig
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Erik B. Craig Date:   Saturday, December 22, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554158 ]

Erik B. Craig commented on GERONIMO-3714:
-----------------------------------------

Viet,
There is a problem with your patch

patching file applications/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditGraph.jsp
Hunk #1 FAILED at 73.
Hunk #2 FAILED at 96.
Hunk #3 FAILED at 113.
Hunk #4 FAILED at 157.
Hunk #5 FAILED at 168.
Hunk #6 FAILED at 219.
Hunk #7 FAILED at 457.
Hunk #8 FAILED at 525.
8 out of 8 hunks FAILED -- saving rejects to file applications/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditGraph.jsp.rej

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Erik B. Craig
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Saturday, December 22, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554170 ]

Viet Hung Nguyen commented on GERONIMO-3714:
--------------------------------------------

that's weird. I just pulled down a fresh trunk and applied the patch just fine. I'll try it on a linux machine when I have the time.

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Erik B. Craig
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Erik B. Craig Date:   Wednesday, December 26, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik B. Craig reassigned GERONIMO-3714:
---------------------------------------

Assignee: Viet Hung Nguyen (was: Erik B. Craig)

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Erik B. Craig Date:   Wednesday, December 26, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554449 ]

Erik B. Craig commented on GERONIMO-3714:
-----------------------------------------

Viet, I manually patched the file it was having problems with...

Committed revision 606930.

Thanks

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Erik B. Craig
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Wednesday, December 26, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554451 ]

Viet Hung Nguyen commented on GERONIMO-3714:
--------------------------------------------

Thanks, I never had the time to set up my linux box at home to redo the patch.

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Fix For: 2.1
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From: Viet Hung Nguyen Date:   Wednesday, December 26, 2007
[ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen resolved GERONIMO-3714.
----------------------------------------

Resolution: Fixed
Fix Version/s: 2.1

Monitoring console does no error checking on add/edit graph timeframe
---------------------------------------------------------------------
Key: GERONIMO-3714
URL: https://issues.apache.org/jira/browse/GERONIMO-3714
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: monitoring
Affects Versions: 2.1
Reporter: Erik B. Craig
Assignee: Viet Hung Nguyen
Fix For: 2.1
Attachments: geronimo-3714.patch
Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
There should be JAVAscript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Next Message: Start failed, Cannot load property editor [org.apache.xbean.propertyeditor.ArrayListEditor]



Programming | Sports | Autos

copyright 2006
Valid XHTML 1.0 Transitional